[PATCH] D123627: Correctly diagnose prototype redeclaration errors in C

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman marked an inline comment as done.
aaron.ballman added a comment.

In D123627#3451269 <https://reviews.llvm.org/D123627#3451269>, @uweigand wrote:

> It looks like this caused the LNT build bot to fail (at least on s390x), because one of the test cases now triggers this error:
> https://lab.llvm.org/buildbot/#/builders/45/builds/6787
>
>   /usr/bin/make -f SingleSource/Regression/C/gcc-c-torture/execute/ieee/CMakeFiles/GCC-C-execute-ieee-compare-fp-4.dir/build.make SingleSource/Regression/C/gcc-c-torture/execute/ieee/CMakeFiles/GCC-C-execute-ieee-compare-fp-4.dir/build
>   /home/uweigand/sandbox/buildbot/clang-s390x-linux-lnt/test/test-suite/SingleSource/Regression/C/gcc-c-torture/execute/ieee/20030331-1.c:6:1: error: conflicting types for 'rintf'
>   rintf ()
>   ^
>   /home/uweigand/sandbox/buildbot/clang-s390x-linux-lnt/test/test-suite/SingleSource/Regression/C/gcc-c-torture/execute/ieee/20030331-1.c:6:1: note: previous implicit declaration is here
>   make[2]: Entering directory '/home/uweigand/sandbox/buildbot/clang-s390x-linux-lnt/test/sandbox/build'
>   /home/uweigand/sandbox/buildbot/clang-s390x-linux-lnt/test/test-suite/SingleSource/Regression/C/gcc-c-torture/execute/ieee/20030331-1.c:29:14: error: too few arguments to function call, expected 1, have 0
>     if (rintf () != -2.0)
>         ~~~~~  ^
>   2 errors generated.
>
> I guess the error is valid, but should either be disabled for this LNT test, or else the test fixed.

Thank you for letting me know -- I've speculatively fixed the issue in 726901d06aab2f92d684d28507711308368c29d6


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123627/new/

https://reviews.llvm.org/D123627