[PATCH] D123533: [clang][extract-api] Add support for true anonymous enums

Tue Apr 12 09:00:47 PDT 2022

zixuw added inline comments.

================
Comment at: clang/test/ExtractAPI/enum.c:693
+        ],
+        "title": "(anonymous)"
+      },
----------------
dang wrote:
> zixuw wrote:
> > So the `Name` of the record is literally `(anonymous)`? I think this might create problems (well I guess we always had this problem) that multiple anonymous records of the same kind getting the same `Name`, and `RecordMap` is indexed with it...
> > We should switch the key of `RecordMap`s to `USR` instead probably.
> Agreed, added this to this patch.
Nice! Thanks Daniel!
Could you please also update the test case to see if it now handles two anonymous records correctly?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123533/new/

https://reviews.llvm.org/D123533