[PATCH] D123533: [clang][extract-api] Add support for true anonymous enums

Daniel Grumberg via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 12 03:21:36 PDT 2022


dang marked 3 inline comments as done.
dang added inline comments.


================
Comment at: clang/test/ExtractAPI/enum.c:693
+        ],
+        "title": "(anonymous)"
+      },
----------------
zixuw wrote:
> So the `Name` of the record is literally `(anonymous)`? I think this might create problems (well I guess we always had this problem) that multiple anonymous records of the same kind getting the same `Name`, and `RecordMap` is indexed with it...
> We should switch the key of `RecordMap`s to `USR` instead probably.
Agreed, added this to this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123533/new/

https://reviews.llvm.org/D123533



More information about the cfe-commits mailing list