[PATCH] D122698: [clangd] Add support to extract method for ExtractFunction Tweak

Fabio Rossini Sluzala via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 5 12:10:26 PDT 2022

FabioRS added a comment.

In D122698#3430211 <https://reviews.llvm.org/D122698#3430211>, @sammccall wrote:

> You're right about the out-of-line function case. Current version looks great!
> I had to rework the logic around merging the edits a little, it wasn't quite correct and was hitting assertions (not sure if you were seeing these locally, but phabricator is not currently running the clangd tests properly).
> Thanks again, landing now.


Here the tests are passing, maybe something is missing in my compilation setup... There are these unsupported tests, but I was thinking they are for another architeture.

  ninja check-clangd
  [1/2] Running the Clangd regression tests
  llvm-lit: /homessddata/Projects/llvm-project/llvm/utils/lit/lit/llvm/config.py:438: note: using clang: /homessddata/Projects/llvm-project/build/bin/clang
  Testing Time: 3.26s
    Unsupported:    6
    Passed     : 1129

You are welcome. Thank you for your patience and time, I am glad to help.

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list