[PATCH] D122698: [clangd] Add support to extract method for ExtractFunction Tweak

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 5 10:50:54 PDT 2022


sammccall added a comment.

You're right about the out-of-line function case. Current version looks great!
I had to rework the logic around merging the edits a little, it wasn't quite correct and was hitting assertions (not sure if you were seeing these locally, but phabricator is not currently running the clangd tests properly).

Thanks again, landing now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122698/new/

https://reviews.llvm.org/D122698



More information about the cfe-commits mailing list