[PATCH] D122822: [Clang][CodeGen]Add constant array support for __builtin_dump_sturct

[Wang Yihan via Phabricator via cfe-commits]

yihanaa added inline comments.


================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2048
+                                              QualType Type) {
+  static llvm::DenseMap<QualType, StringRef> Types;
   if (Types.empty()) {
----------------
erichkeane wrote:
> yihanaa wrote:
> > erichkeane wrote:
> > > Instead of this initialization, can we make this a constexpr constructor/collection of some sort and instantiate it inline?  
> > > Instead of this initialization, can we make this a constexpr constructor/collection of some sort and instantiate it inline?  
> > 
> > I don't have a good idea because it relies on Context to get some types like const char *
> We could at minimum do a in inline-initializer instead of the branch below.
I still haven't come up with a good idea to do it😔


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122822/new/

https://reviews.llvm.org/D122822