[PATCH] D122822: [Clang][CodeGen]Add constant array support for __builtin_dump_sturct

[Erich Keane via Phabricator via cfe-commits]

erichkeane added a comment.

In D122822#3420057 <https://reviews.llvm.org/D122822#3420057>, @yihanaa wrote:

> There is another question, which way should I print for an empty array?
>
> #1: Same as non empty array
>
>   int[0] a = [
>   ]
>
> #2:
>
>   int[0] a = []
>
> The #1's format is more uniform, and the #2 maybe looks a little clearer. What do you think? @erichkeane

I'm not motivated one way or another, I can see the logic to each. I would do whichever doesn't require 'special' handling in any way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122822/new/

https://reviews.llvm.org/D122822