[PATCH] D122542: [flang][driver] Make --version and -version consistent with clang

[Andrzej Warzynski via Phabricator via cfe-commits]

awarzynski added inline comments.


================
Comment at: clang/include/clang/Driver/Options.td:5756
+
+}
+
----------------
ekieri wrote:
> awarzynski wrote:
> > [nit] IMHO this file lacks comments, hence the suggestion :) 
> Sure!
> 
> On the topic of this file's structure, I found the nested "let Flags" quite confusing -- Setting "Flags" inside "def version" does not work, as it would be overwritten by the outer "let Flags" on line 4820. But that is a different patch.
> On the topic of this file's structure, I found the nested "let Flags" quite confusing -- Setting "Flags" inside "def version" does not work, as it would be overwritten by the outer "let Flags" on line 4820. But that is a different patch.

Fixing that is high on my TODO list, just never high enough :( Happy to review if you get a chance to prepare something! ;-) 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122542/new/

https://reviews.llvm.org/D122542