[PATCH] D122542: [flang][driver] Make --version and -version consistent with clang

Emil Kieri via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 28 11:27:55 PDT 2022


ekieri marked an inline comment as done.
ekieri added inline comments.


================
Comment at: clang/include/clang/Driver/Options.td:5756
+
+}
+
----------------
awarzynski wrote:
> [nit] IMHO this file lacks comments, hence the suggestion :) 
Sure!

On the topic of this file's structure, I found the nested "let Flags" quite confusing -- Setting "Flags" inside "def version" does not work, as it would be overwritten by the outer "let Flags" on line 4820. But that is a different patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122542/new/

https://reviews.llvm.org/D122542



More information about the cfe-commits mailing list