[PATCH] D122255: Meta directive runtime support

Abid Malik via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 22 13:45:26 PDT 2022


I quickly went through the D120573. There are many overlapping.


On Tue, Mar 22, 2022 at 4:23 PM Johannes Doerfert via Phabricator <
reviews at reviews.llvm.org> wrote:

> jdoerfert added subscribers: ggeorgakoudis, mikerice, cchen.
> jdoerfert added a comment.
>
> This contains a lot of unrelated changes, leftover comments, etc. As you
> clean up the code, please also include tests. Clang format the patch, go
> over the new code and make sure you follow the coding style. Remove
> unneeded parts (e.g., a map into which you simply push objects then take
> them out to push them into a vector).
>
> Also, have you seen D120573 <https://reviews.llvm.org/D120573>?
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D122255/new/
>
> https://reviews.llvm.org/D122255
>
>

-- 
Abid M. Malik
******************************************************
"I have learned silence from the talkative, toleration from the intolerant,
and kindness from the unkind"---Gibran
"Success is not for the chosen few, but for the few who choose" --- John
Maxwell
"Being a good person does not depend on your religion or status in life,
your race or skin color, political views or culture. IT DEPENDS ON HOW GOOD
YOU TREAT OTHERS"--- Abid
"The Universe is talking to us, and the language of the Universe is
mathematics."----Abid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220322/32a309c0/attachment-0001.html>


More information about the cfe-commits mailing list