[PATCH] D122255: Meta directive runtime support

Johannes Doerfert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 22 13:23:15 PDT 2022


jdoerfert added subscribers: ggeorgakoudis, mikerice, cchen.
jdoerfert added a comment.

This contains a lot of unrelated changes, leftover comments, etc. As you clean up the code, please also include tests. Clang format the patch, go over the new code and make sure you follow the coding style. Remove unneeded parts (e.g., a map into which you simply push objects then take them out to push them into a vector).

Also, have you seen D120573 <https://reviews.llvm.org/D120573>?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122255/new/

https://reviews.llvm.org/D122255



More information about the cfe-commits mailing list