[PATCH] D122102: [clangd] Introduce "add subclass" tweak

[Adrian Vogelsgesang via Phabricator via cfe-commits]

avogelsgesang added a comment.

@adamcz

> Ideally I'd like to see this code action show up as code completion option as well.

I think in the long-term such a "Implement methods" code action should also apply as a quickfix for

  class Base {
     virtual void foo() = 0;
  };
  
  class Derived final : public Base {}; // as a quickfix for "Abstract class is marked 'final'"
  
  auto foo = make_unique<Derived>(); // as a quickfix for "allocating an object of abstract class type 'Derived'"
  Derived d; // as a quickfix for "Variable type 'Derived' is an abstract class"

But that's probably for a future commit. Let's first see that we get the basic functionality into clangd :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122102/new/

https://reviews.llvm.org/D122102