[PATCH] D122102: [clangd] Introduce "add subclass" tweak

Adrian Vogelsgesang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 22 06:46:06 PDT 2022


avogelsgesang added a comment.

Thank for your comments, @adamcz and @njames93!

I agree that a "Implement interface" tweak is probably more useful, and I can imagine to evolve this tweak in that direction.

The main reason, I first went for the "create a new class from scratch" approach, was because I was not sure how to merge the newly inserted methods with the potentially existing methods to get an intuitive order.

How do you think we should further proceed here?

- Do we see value in both an "Implement methods" and an "Add subclass" tweak?
- Are you, @njames93, planning to follow-up on your existing review?
- Would you like me to evolve this patch into an "Implement methods" patch, drawing inspiration from your existing review & the comments on it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122102/new/

https://reviews.llvm.org/D122102



More information about the cfe-commits mailing list