[PATCH] D121873: [clang][extract-api] Add enum support

Daniel Grumberg via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 22 04:40:09 PDT 2022


dang added inline comments.


================
Comment at: clang/include/clang/ExtractAPI/API.h:33
 
+namespace {
+
----------------
I still think this belongs in `APISet`. It belongs there because it defines unique pointers that are specifically tied to the lifetime of `APISet`. Any other thing that needs a reference to things allocated in the APISet should just get the raw pointer out, ideally they should be storing the pointer returned by the `add*` methods of APISet.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121873/new/

https://reviews.llvm.org/D121873



More information about the cfe-commits mailing list