[PATCH] D121873: [clang][extract-api] Add enum support

Zixu Wang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 21 18:40:38 PDT 2022


zixuw added inline comments.


================
Comment at: clang/lib/SymbolGraph/ExtractAPIConsumer.cpp:197
 
+  void recordEnumConstants(EnumRecord *EnumRecord,
+                           const EnumDecl::enumerator_range Constants) {
----------------
dang wrote:
> Should this be static or in an anonymous namespace?
The whole `ExtractAPIVisitor` class is already in an anonymous namespace right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121873/new/

https://reviews.llvm.org/D121873



More information about the cfe-commits mailing list