[PATCH] D118935: [SYCL] Disallow explicit casts between mismatching address spaces
Ronan Keryell via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Mar 18 03:17:36 PDT 2022
keryell added a comment.
In D118935#3389452 <https://reviews.llvm.org/D118935#3389452>, @hvdijk wrote:
> It does make sense, then. A slightly more verbose commit message might have helped though :)
Even better, some comments in the code explaining the "why" would have helped. The commit messages disappear while the comments are right there when the code is read/reviewed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118935/new/
https://reviews.llvm.org/D118935
More information about the cfe-commits
mailing list