[PATCH] D118935: [SYCL] Disallow explicit casts between mismatching address spaces

Harald van Dijk via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 17 08:49:40 PDT 2022


hvdijk added a comment.
Herald added a project: All.

Hi, what is the rationale here? This reuses the logic that was written for OpenCL mode, but in OpenCL mode, it was made an error with the idea that a new keyword `addrspace_cast` could be used in those cases where the user actually wants an address space cast. Here, in SYCL mode, it's just made an error with no way out for the user that I can see if they actually want this. Is this really correct?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118935/new/

https://reviews.llvm.org/D118935



More information about the cfe-commits mailing list