[PATCH] D121757: [clang-format] Take out common code for parsing blocks

Owen Pan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 17 09:25:27 PDT 2022


owenpan added a comment.

In D121757#3389092 <https://reviews.llvm.org/D121757#3389092>, @sstwcw wrote:

> This patch is only intended to reduce the number of times the functionality gets implemented separately.  Any change in behavior would be unintended.  And we also use the `parseIndentedBlock` in Verilog stuff, so it's not just two places.  I will wait for the check-clang result to see what to do.

In that case, I can accept this patch if the review comments are addressed. We can add inserting braces to `switch` in a separate patch. Not sure what name we should use for the function though as it would not be parsing the body of loop statements anymore.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121757/new/

https://reviews.llvm.org/D121757



More information about the cfe-commits mailing list