[PATCH] D121757: [clang-format] Take out common code for parsing blocks

Thu Mar 17 07:03:58 PDT 2022

MyDeveloperDay added a comment.

In D121757#3389218 <https://reviews.llvm.org/D121757#3389218>, @sstwcw wrote:

> For the new stuff I have the option of still adding the function `parseIndentedBlock` but only using it in new code.  Please be more blunt about whether I should close this revision and do it that way.  I guess I might have misunderstood you before from how you reacted when I closed the large patch.

Ok being blunt.. the things you are asking to do, look noble, I just don't always understand the motivation? you are seemingly not fixing anything, you are not adding new tests, its just moving things around, but I don't know your commitment yet? are you hanging around? are you going to fix bugs?

I feel like the guidance for new developers is do a "good first issue", the reviewers have triaged the clang-format issues to try and identify what makes a good first issue for a new contributor

https://github.com/llvm/llvm-project/issues?q=is%3Aopen+label%3A%22good+first+issue%22+label%3Aclang-format

Ultimately if you don't have commit access your going to ask one of us to land this for you, as such we might need persuading, Certainly for me to do that for you I need to see a benefit otherwise its just change in my view.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121757/new/

https://reviews.llvm.org/D121757