[PATCH] D120984: [clang][dataflow] Extend flow conditions from block terminators

Gábor Horváth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 4 16:14:51 PST 2022


xazax.hun added inline comments.


================
Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:123
+  if (Constraints1.empty() || Constraints2.empty()) {
+    // Disjunction of empty set and non-empty set is represented as empty set.
+    return JoinedConstraints;
----------------
xazax.hun wrote:
> Is this actually correct? Or did you mean `Conjunction`?
Oh, sorry. Just realized the empty set is interpreted as `true`. In this case this is correct. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120984/new/

https://reviews.llvm.org/D120984



More information about the cfe-commits mailing list