[PATCH] D120984: [clang][dataflow] Extend flow conditions from block terminators

[Gábor Horváth via Phabricator via cfe-commits]

xazax.hun added inline comments.


================
Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:99
+                       const Environment &Env2, Value &MergedVal,
+                       Environment &Env) {
       return false;
----------------
`MergedEnv`? Also, the documentation above gives a short description of the relationship between `Val1`, `Val2`, and `MergedVal`. But it gives little pointers what are we supposed to do with the `Environment`. 


================
Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:123
+  if (Constraints1.empty() || Constraints2.empty()) {
+    // Disjunction of empty set and non-empty set is represented as empty set.
+    return JoinedConstraints;
----------------
Is this actually correct? Or did you mean `Conjunction`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120984/new/

https://reviews.llvm.org/D120984