[PATCH] D96109: Refactor implementation of -funique-internal-linkage-names.

Sriraman Tallam via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 2 11:18:42 PST 2022


On Wed, Mar 2, 2022 at 11:08 AM Ellis Hoag via Phabricator <
reviews at reviews.llvm.org> wrote:

> ellis added a comment.
> Herald added a subscriber: ormris.
> Herald added a project: All.
>
> Hi @tmsriram. I found a clang crash when using the flag
> `-funique-internal-linkage-names` that only happens after this diff. Would
> you mind taking a look?
>
>   $ cat test.c
>   inline void foo() {}
>   extern void foo();
>   $ clang -funique-internal-linkage-names test.c -c
>

Sure, will take a look.  The first foo here is internal linkage and must be
mangled, not the second.


>
> More details are in this bug report
> https://github.com/llvm/llvm-project/issues/54139
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D96109/new/
>
> https://reviews.llvm.org/D96109
>
>

-- 

Sri    Tallam |

Software Engineer |

tmsriram at google.com |
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220302/50db5917/attachment.html>


More information about the cfe-commits mailing list