<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Mar 2, 2022 at 11:08 AM Ellis Hoag via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">ellis added a comment.<br>
Herald added a subscriber: ormris.<br>
Herald added a project: All.<br>
<br>
Hi @tmsriram. I found a clang crash when using the flag `-funique-internal-linkage-names` that only happens after this diff. Would you mind taking a look?<br>
<br>
  $ cat test.c<br>
  inline void foo() {}<br>
  extern void foo();<br>
  $ clang -funique-internal-linkage-names test.c -c<br></blockquote><div><br></div><div>Sure, will take a look.  The first foo here is internal linkage and must be mangled, not the second.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
More details are in this bug report <a href="https://github.com/llvm/llvm-project/issues/54139" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/issues/54139</a><br>
<br>
<br>
Repository:<br>
  rG LLVM Github Monorepo<br>
<br>
CHANGES SINCE LAST ACTION<br>
  <a href="https://reviews.llvm.org/D96109/new/" rel="noreferrer" target="_blank">https://reviews.llvm.org/D96109/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D96109" rel="noreferrer" target="_blank">https://reviews.llvm.org/D96109</a><br>
<br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><span><br><div dir="ltr" style="margin-left:0pt" align="left"><table style="border:none;border-collapse:collapse"><colgroup><col width="111"><col width="158"><col width="190"><col width="16"></colgroup><tbody><tr style="height:29.25pt"><td style="border-top:1.5pt solid rgb(213,15,37);vertical-align:top;padding:5pt;overflow:hidden"><p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:13pt;font-family:Roboto,sans-serif;color:rgb(136,136,136);font-weight:700;vertical-align:baseline;white-space:pre-wrap">Sri</span><span style="font-size:12pt;font-family:Roboto,sans-serif;color:rgb(136,136,136);vertical-align:baseline;white-space:pre-wrap">    Tallam |</span></p></td><td style="border-top:1.5pt solid rgb(51,105,232);vertical-align:top;padding:5pt;overflow:hidden"><p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:12pt;font-family:Roboto,sans-serif;color:rgb(136,136,136);vertical-align:baseline;white-space:pre-wrap"> Software Engineer |</span></p></td><td style="border-top:1.5pt solid rgb(0,153,57);vertical-align:top;padding:5pt;overflow:hidden"><p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:12pt;font-family:Roboto,sans-serif;color:rgb(136,136,136);vertical-align:baseline;white-space:pre-wrap"> </span><span style="font-size:12pt;font-family:Roboto,sans-serif;color:rgb(17,85,204);vertical-align:baseline;white-space:pre-wrap"><a href="mailto:tmsriram@google.com" target="_blank">tmsriram@google.com</a></span><span style="font-size:12pt;font-family:Roboto,sans-serif;color:rgb(136,136,136);vertical-align:baseline;white-space:pre-wrap"> |</span></p></td></tr></tbody></table></div></span><div></div></div></div></div>