[PATCH] D118333: [RISCV] Use computeTargetABI from llc as well as clang

Alex Bradbury via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 24 03:35:29 PST 2022


asb accepted this revision.
asb added a comment.
This revision is now accepted and ready to land.

In D118333#3329422 <https://reviews.llvm.org/D118333#3329422>, @asb wrote:

> Thanks, I've put this on the agenda for the RISC-V LLVM sync call today. I think this is more attractive than the previous proposal due to unifying logic between llc and Clang. I could see a counter-argument about llc being a low-level tool that should be controlled very explicitly.

I forgot to update on this. Nobody had particularly strong feelings either way, but I think the overall consensus was that this change seemed sensible. Landing this after the LLVM 14 branch also feels like a good time for it. LGTM - thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118333/new/

https://reviews.llvm.org/D118333



More information about the cfe-commits mailing list