[PATCH] D120271: [Clang] Add offload kind to embedded offload object

Mon Feb 21 13:54:02 PST 2022

jhuber6 added a comment.

In D120271#3336277 <https://reviews.llvm.org/D120271#3336277>, @jdoerfert wrote:

> The failing test needs to be adjusted, right?

Yes, forgot about that.

================
Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:187
+    return LHS.OffloadKind == RHS.OffloadKind &&
+           LHS.TheTriple == RHS.TheTriple && LHS.Arch == RHS.Arch;
+  }
----------------
jdoerfert wrote:
> Why not filename in the hash and equal method?
> 
> Can we split this change off into a separate patch please.
The purpose of this implementation is to group device files that share the same triple, ect. The filename is unique so it wouldn't be helpful for that purpose.

I could move this to a separate patch, might be find considering I remove the OffloadKind from this map in the next patch set so it doesn't need to be tied to this one.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120271/new/

https://reviews.llvm.org/D120271