[PATCH] D120271: [Clang] Add offload kind to embedded offload object

Johannes Doerfert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 21 13:50:09 PST 2022


jdoerfert added a comment.

The failing test needs to be adjusted, right?



================
Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:187
+    return LHS.OffloadKind == RHS.OffloadKind &&
+           LHS.TheTriple == RHS.TheTriple && LHS.Arch == RHS.Arch;
+  }
----------------
Why not filename in the hash and equal method?

Can we split this change off into a separate patch please.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120271/new/

https://reviews.llvm.org/D120271



More information about the cfe-commits mailing list