[PATCH] D119095: [clang] Fix redundant functional cast in ConstantExpr

[Kim Gräsman via Phabricator via cfe-commits]

kimgr added a comment.

Having looked at this some more, I wonder if this patch is covering for another problem. Running even the simplest example fails on an assertion in `Sema::BuildCXXTypeConstructExpr`: https://godbolt.org/z/fMPcsh4f3.

It looks like that function is creating the majority of `CXXFunctionalCastExpr`s, so the way the patch shaves off `CXXFunctionalCastExpr` might be compensating for something that should never happen. I don't know much about this, so I can't say for sure.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119095/new/

https://reviews.llvm.org/D119095