[PATCH] D118587: [C++20][Modules][4/8] Handle generation of partition implementation CMIs.

[Chuanqi Xu via Phabricator via cfe-commits]

ChuanqiXu added inline comments.


================
Comment at: clang/test/Modules/cxx20-10-1-ex1.cpp:7-8
+
+// RUN: %clang_cc1 -std=c++20 -emit-module-interface -D TU=1 -x c++ %s \
+// RUN:  -o %t/A_Internals.pcm
+
----------------
In my implementation, I replace ':' to '-' in pcm filename. I do so since I remember this is the behavior of GCC. I think '-' is better than '_' since '_' is possible to occur in name.

And I am surprised that the compiler wouldn't complain about that it couldn't find the corresponding pcm. Since I don't see corresponding code so far.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118587/new/

https://reviews.llvm.org/D118587