[PATCH] D118587: [C++20][Modules][4/8] Handle generation of partition implementation CMIs.

[Nathan Sidwell via Phabricator via cfe-commits]

urnathan accepted this revision.
urnathan added a comment.
This revision is now accepted and ready to land.

with the assert fixed



================
Comment at: clang/lib/Sema/SemaModule.cpp:119
+    default:
+      assert(0 && "how did we get a partition type set?");
+    }
----------------
llvm::unreachable ("how did we get a partition type set?");


================
Comment at: clang/test/Modules/cxx20-10-1-ex1.cpp:21
+
+#if TU == 1
+
----------------
I think I'm getting used to this idiom, or maybe Stockholm has kicked in?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118587/new/

https://reviews.llvm.org/D118587