[PATCH] D119562: Provide fine control of color in run-clang-tidy
Kesavan Yogeswaran via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Feb 11 10:35:03 PST 2022
kesyog added inline comments.
Comment at: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py:96
+ elif use_color is not None:
> Shouldn't it be just `else:`?
There are three cases:
| Argument | `use_color` | Behavior |
| `-use-color` | `True` | `--use-color` is passed to clang-tidy, force enabling color |
| `-no-use-color` | `False` | `--use-color=false` is passed to clang-tidy, force disabling color |
| (none provided) | `None` | Nothing passed to clang-tidy. clang-tidy follows its default coloring behavior |
The case on the highlighted line is the second row of the table, and we have to check that `use_color` is not `None` to exclude the case of the third row.
I was trying to avoid the extra nesting of something like below, but maybe the intent would be clearer?
if use_color is not None:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits