[PATCH] D119061: [Clang] noinline call site attribute

Dávid Bolvanský via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 10 14:09:38 PST 2022

xbolva00 added a comment.

>> Do you plan to also add inline and flatten?

You mean always_inline? Yes, after noinline. The flatten call site attribute - theoretically why not, but it needs to be reworked in LLVM (like always_inline_recursively) before any patch like this one.

>> When I worked on my implementation, I remember that I also ran into the issue of conflicting attributes. I defaulted to whatever the inliner behavior was at the time, but a few folks pointed out to me that this can be very confusing. I think this needs thorough documentation / testing.

Yes, as we mentioned it already, for example always_inline on decl, and noinline on callsite. We should diagnose these cases and always prefer call site attribute. (and as I said, some fixes for inliner are needed).



More information about the cfe-commits mailing list