[PATCH] D119061: [Clang] noinline call site attribute

Jakub Kuderski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 10 13:59:39 PST 2022

kuhar added a comment.

Thanks for working on this, @xbolva00! I don't know this part of the codebase, so won't comment on the patch itself. Just a few questions/suggestions:

1. Do you plan to also add `inline` and `flatten`?

2. When I worked on my implementation, I remember that I also ran into the issue of conflicting attributes. I default to whatever the inliner behavior was at the time, but a few folks pointed out to me that this can be very confusing. I think this needs thorough documentation / testing.



More information about the cfe-commits mailing list