[PATCH] D98110: [NFC][clangd] Use table to collect option aliases

[Yuanfang Chen via Phabricator via cfe-commits]

ychen added inline comments.


================
Comment at: clang-tools-extra/clangd/CompileCommands.cpp:478
+               HELP, METAVAR, VALUES)                                          \
+  {DriverID::OPT_##ID, DriverID::OPT_##ALIAS, (void *)ALIASARGS},
+#include "clang/Driver/Options.inc"
----------------
uabelho wrote:
> gcc warns about casting away "const" here.
> Would it break anything to simply change the type of AliasArgs in the AliasTable to "const char *" and skip this void* cast?
> 
> gcc warns about casting away "const" here.
> Would it break anything to simply change the type of AliasArgs in the AliasTable to "const char *" and skip this void* cast?
> 

Thanks for the report. Fixed in 4f30a5269696.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98110/new/

https://reviews.llvm.org/D98110