[PATCH] D98110: [NFC][clangd] Use table to collect option aliases

Mikael Holmén via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 9 01:58:35 PST 2022


uabelho added inline comments.


================
Comment at: clang-tools-extra/clangd/CompileCommands.cpp:478
+               HELP, METAVAR, VALUES)                                          \
+  {DriverID::OPT_##ID, DriverID::OPT_##ALIAS, (void *)ALIASARGS},
+#include "clang/Driver/Options.inc"
----------------
gcc warns about casting away "const" here.
Would it break anything to simply change the type of AliasArgs in the AliasTable to "const char *" and skip this void* cast?



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98110/new/

https://reviews.llvm.org/D98110



More information about the cfe-commits mailing list