[PATCH] D119362: [NFC] Make file offsets a regex to handle CRLF

Wed Feb 9 11:59:50 PST 2022

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

I think this NFC change is reasonable. We do lose a bit of JSON dumping test coverage from it (I don't see any tests for the offset there now), but I am okay with that as I don't think offsets are something that can be relied upon to be stable values anyway (we pick new source locations for things as we improve fidelity in the compiler).

LGTM, thank you for this!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119362/new/

https://reviews.llvm.org/D119362