[PATCH] D119362: [NFC] Make file offsets a regex to handle CRLF

Chris Bieneman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 9 11:41:19 PST 2022


beanz added a comment.

I realize this is a _big_ silly NFC change, but I figured I'd blast it out there in case anyone objects to the premise.

My goal is to eventually get to the point where Windows developers can use autocrlf (see the note here: https://llvm.org/docs/GettingStarted.html#checkout-llvm-from-git).

My assertion is that the file offset isn't the important thing any of these tests are testing, so making that match fuzzy makes the tests less fragile and get them working with CRLF line endings.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119362/new/

https://reviews.llvm.org/D119362



More information about the cfe-commits mailing list