[PATCH] D117887: [NVPTX] Expose float tys min, max, abs, neg as builtins

Jakub Chlanda via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 9 11:37:24 PST 2022


jchlanda marked 2 inline comments as done.
jchlanda added inline comments.


================
Comment at: llvm/lib/Target/NVPTX/NVPTXTargetTransformInfo.cpp:162
 
     SimplifyAction(Instruction::BinaryOps BinaryOp, FtzRequirementTy FtzReq)
         : BinaryOp(BinaryOp), FtzRequirement(FtzReq) {}
----------------
tra wrote:
> jchlanda wrote:
> > tra wrote:
> > > The new 3-argument constructor above obviates the need for this one.
> > I'm not sure if it does, the 3-way takes `Intrinsic`, while this one `Instruction`.
> You're right. Sorry, my mistake.
np


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117887/new/

https://reviews.llvm.org/D117887



More information about the cfe-commits mailing list