[clang] 8073da0 - [NFC] Fix sign-compare warning in GrammarBNF thanks to int promotion

Erich Keane via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 9 11:26:24 PST 2022


Author: Erich Keane
Date: 2022-02-09T11:25:58-08:00
New Revision: 8073da0beed804d0cef1697b72fdc4151457a327

URL: https://github.com/llvm/llvm-project/commit/8073da0beed804d0cef1697b72fdc4151457a327
DIFF: https://github.com/llvm/llvm-project/commit/8073da0beed804d0cef1697b72fdc4151457a327.diff

LOG: [NFC] Fix sign-compare warning in GrammarBNF thanks to int promotion

Added: 
    

Modified: 
    clang/lib/Tooling/Syntax/Pseudo/GrammarBNF.cpp

Removed: 
    


################################################################################
diff  --git a/clang/lib/Tooling/Syntax/Pseudo/GrammarBNF.cpp b/clang/lib/Tooling/Syntax/Pseudo/GrammarBNF.cpp
index cf3e3e10ec540..b19bed3449ba9 100644
--- a/clang/lib/Tooling/Syntax/Pseudo/GrammarBNF.cpp
+++ b/clang/lib/Tooling/Syntax/Pseudo/GrammarBNF.cpp
@@ -225,7 +225,7 @@ class GrammarBuilder {
             "Token-like name {0} is used as a nonterminal", G.symbolName(SID)));
       }
     }
-    for (RuleID RID = 0; RID + 1 < T.Rules.size(); ++RID) {
+    for (RuleID RID = 0; RID + 1u < T.Rules.size(); ++RID) {
       if (T.Rules[RID] == T.Rules[RID + 1])
         Diagnostics.push_back(
             llvm::formatv("Duplicate rule: `{0}`", G.dumpRule(RID)));


        


More information about the cfe-commits mailing list