[PATCH] D119040: Fix LookupTest where it was missing an assertion

Paul Robinson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 4 14:45:48 PST 2022


probinson added a comment.

By "the EXPECT_EQ was never executed" I mean, replacing it with `assert(false);` does not crash the test.  The string `"a::b::Foo"` was never seen by the Visitor.

Maybe this indicates some much more subtle, deeper problem; I don't know.  This change does cause the EXPECT_EQ to be executed, though.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119040/new/

https://reviews.llvm.org/D119040



More information about the cfe-commits mailing list