[PATCH] D119040: Fix LookupTest where it was missing an assertion

Paul Robinson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 4 14:43:40 PST 2022


probinson created this revision.
probinson added a reviewer: ioeric.
probinson requested review of this revision.

The preceding EXPECT_EQ was never executed; modifying the test input
made that happen.

Found by the Rotten Green Tests project.


https://reviews.llvm.org/D119040

Files:
  clang/unittests/Tooling/LookupTest.cpp


Index: clang/unittests/Tooling/LookupTest.cpp
===================================================================
--- clang/unittests/Tooling/LookupTest.cpp
+++ clang/unittests/Tooling/LookupTest.cpp
@@ -210,7 +210,7 @@
     }
   };
   Visitor.runOver("namespace a { namespace b { class Foo {}; } }\n"
-                  "namespace c { using a::b::Foo; Foo f();; }\n");
+                  "namespace c { a::b::Foo f();; }\n");
 
   // Rename TypeLoc `x::y::Old` to new name `x::Foo` at [0] and check that the
   // type is replaced with "Foo" instead of "x::Foo". Although there is a symbol


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D119040.406110.patch
Type: text/x-patch
Size: 591 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220204/07e17a19/attachment.bin>


More information about the cfe-commits mailing list