[PATCH] D116542: [OpenMP] Add a flag for embedding a file into the module

Mon Jan 31 16:34:46 PST 2022

MaskRay added a comment.

In D116542#3285985 <https://reviews.llvm.org/D116542#3285985>, @jhuber6 wrote:

> In D116542#3285983 <https://reviews.llvm.org/D116542#3285983>, @MaskRay wrote:
>
>> @jhuber6 Please don't do 4a780aa13ee5e1c8268de54ef946200a270127b9 <https://reviews.llvm.org/rG4a780aa13ee5e1c8268de54ef946200a270127b9>.. OK, I was late.
>>
>> See D118666 <https://reviews.llvm.org/D118666> for the proper fix.
>>
>> I'd be better to revert this relevant changes if that doesn't make you feel back.
>> I can prepare the revert.
>
> That's fine, I put it here originally because it was grouped with another similar function. But it's likely that one should be moved as well.

Thanks:) The issue should be resolved by 85dfe19b36ba6e9657612e072c9183ce168fdbbc <https://reviews.llvm.org/rG85dfe19b36ba6e9657612e072c9183ce168fdbbc>. No need to revert.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116542/new/

https://reviews.llvm.org/D116542