[PATCH] D116542: [OpenMP] Add a flag for embedding a file into the module

Joseph Huber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 31 16:24:45 PST 2022


jhuber6 added a comment.

In D116542#3285983 <https://reviews.llvm.org/D116542#3285983>, @MaskRay wrote:

> @jhuber6 Please don't do 4a780aa13ee5e1c8268de54ef946200a270127b9 <https://reviews.llvm.org/rG4a780aa13ee5e1c8268de54ef946200a270127b9>.. OK, I was late.
>
> See D118666 <https://reviews.llvm.org/D118666> for the proper fix.
>
> I'd be better to revert this relevant changes if that doesn't make you feel back.
> I can prepare the revert.

That's fine, I put it here originally because it was grouped with another similar function. But it's likely that one should be moved as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116542/new/

https://reviews.llvm.org/D116542



More information about the cfe-commits mailing list