[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

[Kirill Stoimenov via cfe-commits]

Sorry i just noticed this email. I will take a look next week.

On Sun, Jan 30, 2022, 2:50 AM Simon Pilgrim via Phabricator <
reviews at reviews.llvm.org> wrote:

> RKSimon added inline comments.
>
>
> ================
> Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:1534
>    } else if (StoreInst *SI = dyn_cast<StoreInst>(I)) {
> -    if (!ClInstrumentWrites || ignoreAccess(SI->getPointerOperand()))
> +    if (!ClInstrumentWrites || ignoreAccess(LI, SI->getPointerOperand()))
>        return;
> ----------------
> RKSimon wrote:
> > @kstoimenov You're using the LI pointer for all IgnoreAccess calls which
> is causing nullptr dereference warnings in static analyzer.
> >
> > Should we just be using I or the dyn_cast<> pointers in each case?
> >
> >
> https://llvm.org/reports/scan-build/report-AddressSanitizer.cpp-ignoreAccess-21-f37ec0.html#EndPath
> @kstoimenov Have you been able to check this at all please?
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D112098/new/
>
> https://reviews.llvm.org/D112098
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220130/76d9f14b/attachment.html>