<div dir="auto">Sorry i just noticed this email. I will take a look next week. </div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, Jan 30, 2022, 2:50 AM Simon Pilgrim via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">RKSimon added inline comments.<br>
<br>
<br>
================<br>
Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:1534<br>
   } else if (StoreInst *SI = dyn_cast<StoreInst>(I)) {<br>
-    if (!ClInstrumentWrites || ignoreAccess(SI->getPointerOperand()))<br>
+    if (!ClInstrumentWrites || ignoreAccess(LI, SI->getPointerOperand()))<br>
       return;<br>
----------------<br>
RKSimon wrote:<br>
> @kstoimenov You're using the LI pointer for all IgnoreAccess calls which is causing nullptr dereference warnings in static analyzer.<br>
> <br>
> Should we just be using I or the dyn_cast<> pointers in each case?<br>
> <br>
> <a href="https://llvm.org/reports/scan-build/report-AddressSanitizer.cpp-ignoreAccess-21-f37ec0.html#EndPath" rel="noreferrer noreferrer" target="_blank">https://llvm.org/reports/scan-build/report-AddressSanitizer.cpp-ignoreAccess-21-f37ec0.html#EndPath</a><br>
@kstoimenov Have you been able to check this at all please?<br>
<br>
<br>
Repository:<br>
  rG LLVM Github Monorepo<br>
<br>
CHANGES SINCE LAST ACTION<br>
  <a href="https://reviews.llvm.org/D112098/new/" rel="noreferrer noreferrer" target="_blank">https://reviews.llvm.org/D112098/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D112098" rel="noreferrer noreferrer" target="_blank">https://reviews.llvm.org/D112098</a><br>
<br>
</blockquote></div>