[PATCH] D117830: [HeaderSearch] Track framework name in LookupFile

Cyndy Ishida via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 26 11:12:38 PST 2022


cishida added inline comments.


================
Comment at: clang/lib/Lex/HeaderSearch.cpp:1043
 
     // If this file is found in a header map and uses the framework style of
     // includes, then this header is part of a framework we're building.
----------------
dgoldman wrote:
> cishida wrote:
> > sammccall wrote:
> > > The comment here explicitly say "in a header map and". Unfortunately it doesn't say why, and I don't know enough to guess.
> > nit/reminder: This should be updated now 
> Updated, LMK if you have any suggestions on the wording here.
LGTM


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117830/new/

https://reviews.llvm.org/D117830



More information about the cfe-commits mailing list