[PATCH] D117830: [HeaderSearch] Track framework name in LookupFile

David Goldman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 26 11:02:24 PST 2022


dgoldman marked 2 inline comments as done.
dgoldman added inline comments.


================
Comment at: clang/lib/Lex/HeaderSearch.cpp:1043
 
     // If this file is found in a header map and uses the framework style of
     // includes, then this header is part of a framework we're building.
----------------
cishida wrote:
> sammccall wrote:
> > The comment here explicitly say "in a header map and". Unfortunately it doesn't say why, and I don't know enough to guess.
> nit/reminder: This should be updated now 
Updated, LMK if you have any suggestions on the wording here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117830/new/

https://reviews.llvm.org/D117830



More information about the cfe-commits mailing list