[PATCH] D117181: [PowerPC] Use IEEE long double in proper toolchain

Nemanja Ivanovic via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 21 11:18:07 PST 2022

nemanjai added a comment.

In D117181#3261396 <https://reviews.llvm.org/D117181#3261396>, @jsji wrote:

> So, the proposal is we change the default on Linux,  so we will not change the default based on the gcc version, it is based on OS and clang version only.
> but will emit warning if we detect that the GCC toolchain is too old.
>   Can we just update bool IEEELongDouble = false;  to bool IEEELongDouble = T.isOSLinux(); in clang/lib/Driver/ToolChains/Clang.cpp?

Won't that end up producing a warning on ALL code built on any Linux distro with a GCC toolchain older than 12.1? That would be terrible.
Ultimately, what we care about is checking for the default for the distro toolchain. I am not sure what a good proxy for that is, but I don't think it is "all Linux distros".

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list