[PATCH] D117181: [PowerPC] Use IEEE long double in proper toolchain

Jinsong Ji via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 21 07:46:11 PST 2022

jsji added a comment.

> Would there be a way to query the GCC toolchain for what the default is for `long double`?

There would certainly be ways to  query. But I don't think we should change the default *BASED* on the gcc toolchain installed.

As you mentioned, `I would find it surprising if simply having GCC 12.1 on the system changes my long double default. Imagine if I simply install and use such a toolchain on a machine for whatever reason`

So, the proposal is we change the default on Linux,  so we will not change the default based on the gcc version, 
but will emit warning if we detect that the GCC toolchain is too old.

  Can we just update bool IEEELongDouble = false;  to bool IEEELongDouble = T.isOSLinux(); in clang/lib/Driver/ToolChains/Clang.cpp?

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list