[PATCH] D96248: [OpenMP][AMDGPU] Add support for linking libomptarget bitcode

Johannes Doerfert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Jan 8 11:31:42 PST 2022


jdoerfert reopened this revision.
jdoerfert added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/include/clang/Driver/Options.td:948
 def libomptarget_nvptx_bc_path_EQ : Joined<["--"], "libomptarget-nvptx-bc-path=">, Group<i_Group>,
   HelpText<"Path to libomptarget-nvptx bitcode library">;
 def dD : Flag<["-"], "dD">, Group<d_Group>, Flags<[CC1Option]>,
----------------
Why do we need two options that literally do the same thing?
I cannot think of a use case where we would specify two distinct paths, can anyone else?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96248/new/

https://reviews.llvm.org/D96248



More information about the cfe-commits mailing list