[PATCH] D114317: [clang-tidy][WIP] Do not run perfect alias checks

Carlos Galvez via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Jan 8 10:24:28 PST 2022


carlosgalvezp added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/ClangTidy.cpp:442
+        if (PrimaryCheckValue != Value) {
+          std::cout << "Alias check \"" << CheckName.str() << "\" of \""
+                    << PrimaryCheckName.str() << "\""
----------------
Jeroen wrote:
> I'm not sure if you have this in for testing purpose or not, though I really like to have this message. If I would be having 2 aliases active with different options, it would be nice to know about that. So please keep this in!
> Preferably, we would only configure it once, though that's dreaming.
Yep, all printouts are just for my own testing, but good to hear it's useful info for production! I'll see if I get some time and clean this up.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114317/new/

https://reviews.llvm.org/D114317



More information about the cfe-commits mailing list